experiments: Switch to filewatcher/v2 #655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fishy
requested review from
kylelemons,
konradreiche and
pacejackson
and removed request for
a team
|
Based on #654 |
konradreiche
approved these changes
May 22, 2024
pacejackson
approved these changes
May 23, 2024
fishy
force-pushed
the
filewatcher-v2-users
branch
from
52168a3 to
df7d154
Compare
fishy
force-pushed
the
filewatcher-v2-users
branch
from
df7d154 to
66ec8cd
Compare
fishy
force-pushed
the
filewatcher-v2-users
branch
from
66ec8cd to
8cbcadc
Compare
fishy
force-pushed
the
filewatcher-v2-users
branch
from
8cbcadc to
f0e1ee2
Compare
Note: secrets package is not switching because filewatcher.MockFileWatcher is part of its API so switching to v2 will be a breaking change for secrets package.
fishy
force-pushed
the
filewatcher-v2-users
branch
from
f0e1ee2 to
d04f7ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: secrets package is not switching because filewatcher.MockFileWatcher is part of its API so switching to v2 will be a breaking change for secrets package.