Resolve review comments

Signed-off-by: divyansh42 <[email protected]>

.github/workflows/verify-build.yml

@@ -78,7 +78,7 @@ jobs:
         uses: ./buildah-build/
         with:
           image: ${{ env.IMAGE_NAME }}
-          tags: 'latest v2'
+          tags: 'latest ${{ github.sha }}'
           base-image: 'registry.access.redhat.com/openjdk/openjdk-11-rhel7'
           # To avoid hardcoding a particular version of the binary.
           content: |

README.md

@@ -34,15 +34,15 @@ After building your image, use [push-to-registry](https://github.com/redhat-acti
     <td>tags</td>
     <td>No</td>
     <td>
-      The tags of the image to build. For multiple tags, seperate by a space. For example, <code>v1 v0.1</code>.<br>
+      The tags of the image to build. For multiple tags, seperate by a space. For example, <code>latest ${{ github.sha }}</code>.<br>
       Default: <code>latest</code>
     </td>
   </tr>
 
   <tr>
     <td>base-image</td>
     <td>No</td>
-    <td>The base image to use to create the initial container.</td>
+    <td>The base image to use for the container.</td>
   </tr>
 
   <tr>
@@ -123,8 +123,8 @@ envs: |
 `image`: The name of the built image.<br>
 For example, `spring-image`.
 
-`tags`: The list of tags delimeted by a space.<br>
-For example, `v1 v0.1`.
+`tags`: A list of the tags that were created, separated by spaces.<br>
+For example, `latest ${{ github.sha }}`.
 
 ## Build Types
 

action.yml

@@ -9,7 +9,7 @@ inputs:
     description: 'The name (reference) of the image to build'
     required: true
   tags:
-    description: 'The tags of the image to build. For multiple tags, seperate by a space. For example, "v1 v0.1".'
+    description: 'The tags of the image to build. For multiple tags, seperate by a space. For example, "latest ${{ github.sha }}".'
     required: false
     default: latest
   base-image:
@@ -38,17 +38,17 @@ inputs:
     description: 'List of environment variables to be set when running containers based on image'
     required: false
   build-args:
-    description: 'List of --build-args to pass to buildah.'
+    description: 'List of --build-args to pass to buildah'
     required: false
   oci:
-    description: 'Set to true to build using the OCI image format instead of the Docker image format.'
+    description: 'Set to true to build using the OCI image format instead of the Docker image format'
     default: 'false'
     required: false
 outputs:
   image:
     description: 'Name of the image built'
   tags:
-    description: 'List of tags delimeted by a space'
+    description: 'List of the tags that were created, separated by spaces'
 runs:
   using: 'node12'
   main: 'dist/index.js'

package.json

@@ -26,11 +26,11 @@
     "language-recognizer": "0.0.1"
   },
   "devDependencies": {
-    "@redhat-actions/eslint-config": "^1.2.4",
+    "@redhat-actions/eslint-config": "^1.2.11",
     "@redhat-actions/tsconfig": "^1.1.1",
     "@types/node": "^12",
-    "@typescript-eslint/eslint-plugin": "^4.14.0",
-    "@typescript-eslint/parser": "^4.14.0",
+    "@typescript-eslint/eslint-plugin": "^4.14.1",
+    "@typescript-eslint/parser": "^4.14.1",
     "@vercel/ncc": "^0.25.1",
     "eslint": "^7.18.0",
     "typescript": "^4.0.5"

src/buildah.ts

@@ -98,8 +98,10 @@ export class BuildahCli implements Buildah {
         core.debug("commit");
         core.debug(container);
         core.debug(newImageName);
-        const args: string[] = [ "commit", ...BuildahCli.getImageFormatOption(useOCI),
-            "--squash", container, newImageName ];
+        const args: string[] = [
+            "commit", ...BuildahCli.getImageFormatOption(useOCI),
+            "--squash", container, newImageName,
+        ];
         return this.execute(args);
     }
 
@@ -130,10 +132,10 @@ export class BuildahCli implements Buildah {
         finalExecOptions.ignoreReturnCode = true;     // the return code is processed below
 
         finalExecOptions.listeners = {
-            stdline: (line) : void => {
+            stdline: (line): void => {
                 stdout += line + "\n";
             },
-            errline: (line) :void => {
+            errline: (line):void => {
                 stderr += line + "\n";
             },
         };

src/index.ts

@@ -12,10 +12,10 @@ export async function run(): Promise<void> {
     const buildahPath = await io.which("buildah", true);
     const cli: BuildahCli = new BuildahCli(buildahPath);
 
-    const workspace = process.env.GITHUB_WORKSPACE || "";
+    const workspace = process.env.GITHUB_WORKSPACE || process.cwd();
     const dockerFiles = getInputList("dockerfiles");
     const image = core.getInput("image", { required: true });
-    const tags = core.getInput("tags");
+    const tags = core.getInput("tags") || "latest";
     const tagsList: string[] = tags.split(" ");
     const newImage = `${image}:${tagsList[0]}`;
     const useOCI = core.getInput("oci") === "true";
@@ -46,8 +46,8 @@ async function doBuildUsingDockerFiles(
 
     const context = path.join(workspace, core.getInput("context"));
     const buildArgs = getInputList("build-args");
-    const inputdockerFiles = dockerFiles.map((file) => path.join(workspace, file));
-    await cli.buildUsingDocker(newImage, context, inputdockerFiles, buildArgs, useOCI);
+    const dockerFileAbsPaths = dockerFiles.map((file) => path.join(workspace, file));
+    await cli.buildUsingDocker(newImage, context, dockerFileAbsPaths, buildArgs, useOCI);
 }
 
 async function doBuildFromScratch(