Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add OWNERS for ui #5465

Merged
merged 1 commit into from
Feb 17, 2025
Merged

add OWNERS for ui #5465

merged 1 commit into from
Feb 17, 2025

Conversation

sahil143
Copy link
Contributor

@sahil143 sahil143 commented Feb 5, 2025

Added OWNERS file for konflux-ui

@openshift-ci openshift-ci bot requested review from bamachrn and dirgim February 5, 2025 12:43
@hugares
Copy link
Contributor

hugares commented Feb 5, 2025

@sahil143 I will invite everyone that are not already in the org, once they accepted the invite, we will be able to get this change in

dirgim
dirgim approved these changes Feb 5, 2025
View reviewed changes
Copy link
Member

@dirgim dirgim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci openshift-ci bot added the approved label Feb 5, 2025
@hugares
Copy link
Contributor

hugares commented Feb 5, 2025

@sahil143 I will invite everyone that are not already in the org, once they accepted the invite, we will be able to get this change in

Invites sent

abhinandan13jan
abhinandan13jan reviewed Feb 11, 2025
View reviewed changes
components/konflux-ui/OWNERS
- sahil143
- testcara

reviewers:
Copy link

@abhinandan13jan abhinandan13jan Feb 11, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add janaki & rakesh as reviewers

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is for deployment only

@sahil143
Copy link
Contributor Author

/verify-owners

hugares
hugares approved these changes Feb 17, 2025
View reviewed changes
Copy link
Contributor

@hugares hugares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Feb 17, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dirgim, hugares, sahil143

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit f3e8ad4 into redhat-appstudio:main Feb 17, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhinandan13jan abhinandan13jan abhinandan13jan left review comments

@hugares hugares hugares approved these changes

@dirgim dirgim dirgim approved these changes

@bamachrn bamachrn Awaiting requested review from bamachrn

Assignees

@hugares hugares

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sahil143 @hugares @abhinandan13jan @dirgim