Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add domain proxy params #2335

Merged
merged 2 commits into from
Jan 13, 2025
Merged

Add domain proxy params #2335

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d0c2001
Add domain proxy params
rnc Jan 7, 2025
4afe1a4
Rename whitelist to allowlist.
tecarter94 Jan 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 41 additions & 0 deletions deploy/pipeline/mw-pipeline-v0.1.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,27 @@ spec:
type: string
- name: caTrustConfigMapName
type: string
- name: DOMAIN_PROXY_TARGET_ALLOWLIST
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I've just changed whitelist to allowlist as a part of this PR. So this PR now depends on my domain proxy changes:
project-ncl/domain-proxy#7

type: string
default: "localhost,gateway.indy.corp.stage.redhat.com,cdn-ubi.redhat.com,repo1.maven.org,repo.scala-sbt.org,scala.jfrog.io,repo.typesafe.com,jfrog-prod-usw2-shared-oregon-main.s3.amazonaws.com"
- name: DOMAIN_PROXY_ENABLE_INTERNAL_PROXY
type: string
default: "true"
- name: DOMAIN_PROXY_INTERNAL_PROXY_HOST
type: string
default: "localhost"
- name: DOMAIN_PROXY_INTERNAL_PROXY_PORT
type: string
default: "8081"
- name: DOMAIN_PROXY_INTERNAL_PROXY_USER
type: string
default: "$(params.BUILD_ID)+tracking"
- name: DOMAIN_PROXY_INTERNAL_PROXY_PASSWORD
type: string
default: "$(params.ACCESS_TOKEN)"
- name: DOMAIN_PROXY_INTERNAL_NON_PROXY_HOSTS
type: string
default: "localhost,gateway.indy.corp.stage.redhat.com"
- name: ENABLE_INDY_PROXY
type: string
- name: INDY_PROXY_CLIENT_ID
Expand Down Expand Up @@ -138,6 +159,26 @@ spec:
- PROXY_URL=$(params.MVN_REPO_DEPENDENCIES_URL)
- BUILD_ID=$(params.BUILD_ID)
- ACCESS_TOKEN=$(params.ACCESS_TOKEN)
- name: BUILD_IMAGE
value: quay.io/redhat-user-workloads/konflux-jbs-pnc-tenant/domain-proxy:latest
- name: HERMETIC
value: "true"
- name: ENABLE_DOMAIN_PROXY
value: "true"
- name: DOMAIN_PROXY_TARGET_ALLOWLIST
value: $(params.DOMAIN_PROXY_TARGET_ALLOWLIST)
- name: DOMAIN_PROXY_ENABLE_INTERNAL_PROXY
value: $(params.DOMAIN_PROXY_ENABLE_INTERNAL_PROXY)
- name: DOMAIN_PROXY_INTERNAL_PROXY_HOST
value: $(params.DOMAIN_PROXY_INTERNAL_PROXY_HOST)
- name: DOMAIN_PROXY_INTERNAL_PROXY_PORT
value: $(params.DOMAIN_PROXY_INTERNAL_PROXY_PORT)
- name: DOMAIN_PROXY_INTERNAL_PROXY_USER
value: $(params.DOMAIN_PROXY_INTERNAL_PROXY_USER)
- name: DOMAIN_PROXY_INTERNAL_PROXY_PASSWORD
value: $(params.DOMAIN_PROXY_INTERNAL_PROXY_PASSWORD)
- name: DOMAIN_PROXY_INTERNAL_NON_PROXY_HOSTS
value: $(params.DOMAIN_PROXY_INTERNAL_NON_PROXY_HOSTS)
taskRef:
#resolver: bundles
#params:
Expand Down
Loading