Rename whitelist to allowlist #2338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnc
approved these changes
Jan 13, 2025
|
I presume we need project-ncl/domain-proxy#7 merged first? |
|
/retest |
1 similar comment
|
/retest |
rnc
force-pushed
the
rename-domain-proxy-whitelist
branch
from
f50496f to
cb42e4c
Compare
|
New changes are detected. LGTM label has been removed. |
|
@tecarter94: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
rnc
force-pushed
the
rename-domain-proxy-whitelist
branch
from
8fcd8d6 to
4589889
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename whitelist to allowlist. Restore ability to override domain proxy version.
https://issues.redhat.com/browse/JBS-80