Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat : Valid (Single/Multi-Namespaced) Operator Installation in tenant namespace #2589

Merged
merged 8 commits into from
Feb 10, 2025
Merged

feat : Valid (Single/Multi-Namespaced) Operator Installation in tenant namespace #2589

merged 8 commits into from
Feb 10, 2025
+384 −124

Conversation

bnshr
Copy link
Contributor

@bnshr bnshr commented Nov 25, 2024

Refers the issue

@bnshr bnshr marked this pull request as draft November 25, 2024 14:08
@bnshr bnshr force-pushed the CNFCERT-1088 branch 3 times, most recently from 98cb58b to 56d4773 Compare November 25, 2024 14:39
@dcibot
Copy link
Collaborator

dcibot commented Nov 25, 2024

from change #2589:

@bnshr bnshr force-pushed the CNFCERT-1088 branch 2 times, most recently from 1f928d0 to e3fd824 Compare November 25, 2024 15:09
@dcibot
Copy link
Collaborator

dcibot commented Nov 25, 2024

from change #2589:

@bnshr bnshr force-pushed the CNFCERT-1088 branch 2 times, most recently from 33278d6 to 26570f7 Compare November 25, 2024 16:20
@dcibot
Copy link
Collaborator

dcibot commented Nov 25, 2024

from change #2589:

@bnshr bnshr marked this pull request as ready for review November 25, 2024 19:17
sebrandon1
sebrandon1 reviewed Nov 25, 2024
View reviewed changes
Copy link
Member

@sebrandon1 sebrandon1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial set of comments

tests/operator/suite.go Outdated Show resolved Hide resolved
tests/operator/helper.go Outdated Show resolved Hide resolved
tests/operator/helper.go Outdated Show resolved Hide resolved
tests/operator/helper.go Outdated Show resolved Hide resolved
@bnshr bnshr force-pushed the CNFCERT-1088 branch 5 times, most recently from fad4dfa to 822dfe9 Compare November 26, 2024 16:15
@bnshr bnshr force-pushed the CNFCERT-1088 branch 2 times, most recently from 2ba0ff8 to 475f7b6 Compare November 27, 2024 20:29
@bnshr bnshr mentioned this pull request Nov 28, 2024
Merged
greyerof
greyerof reviewed Nov 29, 2024
View reviewed changes
tests/operator/suite.go Outdated Show resolved Hide resolved
@bnshr bnshr force-pushed the CNFCERT-1088 branch 2 times, most recently from 9e3e4e5 to 44f8fb6 Compare February 3, 2025 15:32
@bnshr bnshr force-pushed the CNFCERT-1088 branch 3 times, most recently from 0f29753 to 4f79e59 Compare February 3, 2025 15:59
edcdavid
edcdavid reviewed Feb 3, 2025
View reviewed changes
tests/operator/suite.go Outdated Show resolved Hide resolved
@bnshr bnshr force-pushed the CNFCERT-1088 branch 9 times, most recently from 8dc7961 to f73d1f1 Compare February 5, 2025 09:51
edcdavid
edcdavid reviewed Feb 5, 2025
View reviewed changes
tests/operator/helper.go Outdated Show resolved Hide resolved
edcdavid
edcdavid reviewed Feb 5, 2025
View reviewed changes
tests/operator/helper.go Outdated Show resolved Hide resolved
@bnshr bnshr force-pushed the CNFCERT-1088 branch 2 times, most recently from 21bb9b8 to 29ce7b7 Compare February 7, 2025 10:28
edcdavid
edcdavid reviewed Feb 7, 2025
View reviewed changes
Copy link
Member

@edcdavid edcdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there! few comments on the results presentation

tests/operator/suite.go Outdated Show resolved Hide resolved
tests/operator/suite.go Outdated Show resolved Hide resolved
tests/operator/suite.go Outdated Show resolved Hide resolved
tests/operator/suite.go Outdated Show resolved Hide resolved
tests/operator/suite.go Outdated Show resolved Hide resolved
tests/operator/suite.go Outdated Show resolved Hide resolved
tests/operator/helper.go Outdated Show resolved Hide resolved
tests/operator/helper.go Outdated Show resolved Hide resolved
tests/operator/helper.go Outdated Show resolved Hide resolved
@bnshr bnshr force-pushed the CNFCERT-1088 branch 2 times, most recently from 7274de6 to 716ee21 Compare February 7, 2025 16:52
@bnshr bnshr changed the title feat : Valid (SingleNamespaced) Operator Installation in tenant namespace feat : Valid (Single/Multi-Namespaced) Operator Installation in tenant namespace Feb 7, 2025
@bnshr bnshr merged commit af0be3a into main Feb 10, 2025
33 of 34 checks passed
@bnshr bnshr deleted the CNFCERT-1088 branch February 10, 2025 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebrandon1 sebrandon1 sebrandon1 left review comments

@edcdavid edcdavid edcdavid left review comments

@greyerof greyerof greyerof approved these changes

Assignees
No one assigned
Labels
v1.6 BP Update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bnshr @dcibot @greyerof @sebrandon1 @edcdavid