Fix amq router race condition #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add retries when starting AMQP server to deal with the race condition when AMQP router starts later than cloud-event-proxy service, for example when a node is rebooted. Signed-off-by: Jack Ding <[email protected]>
aneeshkp
reviewed
Dec 2, 2022
| if instance == nil || instance.Router == nil { | ||
| return nil, errorhandler.AMQPConnectionError{Desc: "amqp connection error"} | ||
| return nil, errorhandler.AMQPConnectionError{} |
There was a problem hiding this comment.
text might be used for parsing some where
There was a problem hiding this comment.
The AMQPConnectionError itself already has description.
Before removing description:
ERRO[0000] error starting amqp at amqp:localhost:5672 error: amqp connection error amqp connection error
WARN[0000] requires QPID router installed to function fully amqp connection error amqp connection error
After removing description:
ERRO[0000] error starting amqp at amqp:localhost:5672 error: amqp connection error
WARN[0000] requires QPID router installed to function fully amqp connection error
aneeshkp
approved these changes
Dec 2, 2022
|
/cherrypick release-4.12 |
|
/cherry-pick release-4.12 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add retries when starting AMQP server to deal with the race condition when AMQP router starts later than cloud-event-proxy service, for example when a node is rebooted.
Timeout for retry duration is set to 30 seconds.
Signed-off-by: Jack Ding [email protected]