Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New role to detect env_authorized_key path #4550

Merged
merged 3 commits into from
Mar 29, 2022

Conversation

fridim
Copy link
Collaborator

@fridim fridim commented Mar 29, 2022

This change, if applied, add a new role to detect the env_authorized_key
to use, see its readme.

  • use those facts instead of role defaults in diverse places
  • run 'locate_env_authorized_key' role at the beginning of infra, after
    key creation
SUMMARY
ISSUE TYPE
  • Bugfix Pull Request

This change, if applied, add a new role to detect the env_authorized_key
to use, see its readme.

- use those facts instead of role defaults in diverse places
- run 'locate_env_authorized_key' role at the beginning of infra, after
  key creation
@fridim fridim requested a review from a team as a code owner March 29, 2022 09:47
@fridim fridim changed the title New role to detect env_authorized_key path [WIP] New role to detect env_authorized_key path Mar 29, 2022
@fridim fridim changed the title [WIP] New role to detect env_authorized_key path New role to detect env_authorized_key path Mar 29, 2022
Copy link
Collaborator

@jkupferer jkupferer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though, even include_role should have a task name.

@fridim fridim merged commit cf120f7 into development Mar 29, 2022
@fridim fridim deleted the locate_env_authorized_key branch March 29, 2022 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants