Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add role to get env_authorized_key_path to azure-create-inventory #5267

Merged
merged 1 commit into from
Aug 19, 2022
Merged

add role to get env_authorized_key_path to azure-create-inventory #5267

merged 1 commit into from
Aug 19, 2022

Conversation

newgoliath
Copy link
Collaborator

No description provided.

@newgoliath newgoliath requested a review from a team as a code owner August 19, 2022 19:17
tonykay
tonykay approved these changes Aug 19, 2022
View reviewed changes
Copy link
Collaborator

@tonykay tonykay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But let "{{item.osProfile.computerName|default(item.name)}}" breath :)

"{{ item.osProfile.computerName | default(item.name) }}"

I know it's not the PR topic :)

@newgoliath newgoliath merged commit 7ea5d75 into development Aug 19, 2022
@newgoliath newgoliath deleted the judd-hybrid-cloud-azure-start-fails branch August 19, 2022 20:46
@newgoliath
Copy link
Collaborator Author

Feel free to clean up the entire codebase.

For now, I'm going to not touch anything not directly related to my work - so I can focus on the task at hand without distraction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonykay tonykay tonykay approved these changes

@rut31337 rut31337 rut31337 approved these changes

@perryrivera1 perryrivera1 perryrivera1 approved these changes

Assignees
No one assigned
Labels
azure core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@newgoliath @tonykay @rut31337 @perryrivera1