Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in type & source to collections #67

Merged

Conversation

davidcba1
Copy link
Contributor

@davidcba1 davidcba1 commented Jan 23, 2023

What does this PR do?

Adds in a couple of more types to the template for requirements.yml to allow collections to be source from an internal url (eg .tar.gz file)

How should this be tested?

Configure a collection to point to a file directly, rather than a galaxy API eg (Mainly used for internal repos like artifactory etc)

collections: 
 - name community.general
   type: url
   source: https://galaxy.ansible.com/download/community-general-6.2.0.tar.gz

Is there a relevant Issue open for this?

https://github.com/redhat-cop/ee_utilities/discussions/66

Other Relevant info, PRs, etc

N/A

@davidcba1 davidcba1 marked this pull request as ready for review January 23, 2023 06:26
Copy link

@simon-mags simon-mags left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this by specifying a collection with a type of URL and a https URL to a .tar.gz file and it worked as expected.

Copy link
Contributor

@sean-m-sullivan sean-m-sullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am approving this, its a good addition.

However in the future a test to ee_utilities/.github/tests/ee_builder.yaml. I'll be following up with another PR with this.

@sean-m-sullivan sean-m-sullivan merged commit d750eec into redhat-cop:devel Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants