Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add code completion for when clause #209

Closed
jeffmaury opened this issue Sep 11, 2020 · 2 comments · Fixed by #223
Closed

Add code completion for when clause #209

jeffmaury opened this issue Sep 11, 2020 · 2 comments · Fixed by #223
Assignees
@lstocchi
Milestone
Sprint #190

Comments

@jeffmaury
Copy link
Member

Pipeline added a new field when for simpler conditional execution of tasks. (See tektoncd/pipeline#3135)
We may provide some code completion, note sure because the doc mentions that both Input and Values are static.
@lstocchi lstocchi added this to the Sprint #190 milestone Sep 15, 2020
@jerop
Copy link

jerop commented Sep 15, 2020

@jeffmaury to clarify, the inputs or values can be static or variables (parameter or task results variables are supported now)

@lstocchi
Copy link
Contributor

Thanks for the clarification @jerop

lstocchi added a commit to lstocchi/intellij-tekton that referenced this issue Sep 18, 2020
@lstocchi
add initial code completion for when clause (redhat-developer#209)
81ff9dd 
Signed-off-by: Luca Stocchi <[email protected]>
@lstocchi lstocchi mentioned this issue Sep 18, 2020
Merged
lstocchi added a commit that referenced this issue Sep 30, 2020
@lstocchi
Add code completion for when clause (#223)
bcd19ff 
* fix issue with generic code completion that is not displayed in list

Signed-off-by: Luca Stocchi <[email protected]>

* add initial code completion for when clause (#209)

Signed-off-by: Luca Stocchi <[email protected]>

* restore old test content

Signed-off-by: Luca Stocchi <[email protected]>

* add tests

Signed-off-by: Luca Stocchi <[email protected]>

* add virtual file system

Signed-off-by: Luca Stocchi <[email protected]>

* clean

Signed-off-by: Luca Stocchi <[email protected]>

* fix when operator completion uppercase

Signed-off-by: Luca Stocchi <[email protected]>

* fixed test

Signed-off-by: Luca Stocchi <[email protected]>
@lstocchi lstocchi mentioned this issue Oct 26, 2020
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lstocchi lstocchi

Labels
None yet
Projects
None yet
Milestone
Sprint #190
Development

Successfully merging a pull request may close this issue.

Add code completion for when clause lstocchi/intellij-tekton
3 participants
@jeffmaury @jerop @lstocchi