Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

collect logs for ingress and observability namespaces and group by logtype #200

Conversation

StevenTobin
Copy link
Collaborator

@StevenTobin StevenTobin commented Mar 23, 2023

  • Collect logs for ingress namespace
    • We have a custom ingress so we should collect logs for it
  • Collect logs for observability namespace
    • A namespace we manage so we should collect the logs
  • Group by logType
    • This will make precreation of resources much more straightforward

Verification

  1. Deploy this to an OSD cluster.
  2. Verify the new namespaces are in the clusterLogForwarder resource
  3. Verify the GroupBy var in the ClusterlogForwarder is logType

@StevenTobin StevenTobin requested review from vmanley and pb82 March 23, 2023 14:04
@codecov-commenter
Copy link

Codecov Report

Merging #200 (5765080) into main (21c913b) will decrease coverage by 2.68%.
The diff coverage is 33.22%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #200      +/-   ##
==========================================
- Coverage   41.61%   38.94%   -2.68%     
==========================================
  Files          19       22       +3     
  Lines        2667     3166     +499     
==========================================
+ Hits         1110     1233     +123     
- Misses       1548     1919     +371     
- Partials        9       14       +5     
Impacted Files Coverage Δ
api/v1/observability_types.go 73.68% <ø> (ø)
api/v1/observability_webhook.go 79.10% <ø> (ø)
controllers/model/token_refresher_resources.go 100.00% <ø> (ø)
controllers/model/token_resources.go 100.00% <ø> (ø)
...rs/reconcilers/configuration/grafana_dashboards.go 35.97% <0.00%> (-0.45%) ⬇️
...trollers/reconcilers/configuration/pod_monitors.go 42.85% <ø> (ø)
...lers/reconcilers/configuration/prometheus_rules.go 28.44% <ø> (ø)
...llers/reconcilers/configuration/token_refresher.go 10.92% <0.00%> (-0.86%) ⬇️
...ng_installation/logging_installation_reconciler.go 5.03% <0.00%> (-0.94%) ⬇️
controllers/reconcilers/token/token_manager.go 8.71% <ø> (ø)
... and 12 more

... and 1 file with indirect coverage changes

Copy link
Collaborator

@vmanley vmanley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @StevenTobin

@vmanley vmanley merged commit 633383a into redhat-developer:main Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants