fix: adjust startup, liveness and readiness... #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adjust startup, liveness and readiness probes settings Startup probe settings seem to have been added in the upstream Backstage Chart in [1], but the current settings do not allow the RHDH Chart for the liveness probe to be triggered sufficiently enough for the app to be considered live. This adjust such settings by accounting for the worst case scenario where the application might take a bit long to start. This also aligns the probe endpoints with the upstream chart. [1] backstage/charts#216 * Update Chart version * Update charts/backstage/values.yaml Co-authored-by: Patrick Knight <[email protected]> Co-authored-by: Gustavo Lira e Silva <[email protected]> * Add comment explaining why there is no 'initialDelaySeconds' on both liveness and readiness probes Co-authored-by: Nick Boldt <[email protected]> --------- Co-authored-by: Patrick Knight <[email protected]> Co-authored-by: Gustavo Lira e Silva <[email protected]> Co-authored-by: Nick Boldt <[email protected]> fix URLs and bump to 2.24.2 in 1.4 branch Signed-off-by: RHDH Build (rhdh-bot) <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
fix: adjust startup, liveness and readiness probes settings (#50)
Startup probe settings seem to have been added in the upstream Backstage Chart
in [1], but the current settings do not allow the RHDH Chart for the
liveness probe to be triggered sufficiently enough for the app to be
considered live.
This adjust such settings by accounting for the worst case scenario
where the application might take a bit long to start.
This also aligns the probe endpoints with the upstream chart.
[1] backstage/charts#216
Update Chart version
Update charts/backstage/values.yaml
Co-authored-by: Patrick Knight [email protected]
Co-authored-by: Gustavo Lira e Silva [email protected]
Co-authored-by: Nick Boldt [email protected]
Co-authored-by: Patrick Knight [email protected]
Co-authored-by: Gustavo Lira e Silva [email protected]
Co-authored-by: Nick Boldt [email protected]
fix URLs and bump to 2.24.2 in 1.4 branch
Signed-off-by: RHDH Build (rhdh-bot) [email protected]
Screenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
N/A (or see commit message above for issue number)
How to test this PR?
N/A
PR Checklist
As the author of this Pull Request I made sure that:
Reviewers
Reviewers, please comment how you tested the PR when approving it.