Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate from janus showcase to gh/rhd/rhdh and quay.io/rhdh-community/rhdh (RHIDP-1022) #638

Merged
merged 3 commits into from
Jan 9, 2025

Conversation

nickboldt
Copy link
Member

What does this PR do?

chore: migrate from janus showcase to gh/rhd/rhdh and quay.io/rhdh-community/rhdh (RHIDP-1022)

Signed-off-by: Nick Boldt [email protected]

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

N/A (or see commit message above for issue number)

How to test this PR?

N/A

PR Checklist

As the author of this Pull Request I made sure that:

  • Code produced is complete
  • Code builds without errors
  • Tests are covering the bugfix
  • Relevant user documentation updated
  • Relevant contributing documentation updated

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@openshift-ci openshift-ci bot requested review from coreydaley and kim-tsao January 9, 2025 01:08
@nickboldt nickboldt requested review from rm3l and removed request for coreydaley and kim-tsao January 9, 2025 01:08
@nickboldt nickboldt changed the title chore: migrate from janus showcase to... chore: migrate from janus showcase to gh/rhd/rhdh and quay.io/rhdh-community/rhdh (RHIDP-1022) Jan 9, 2025
rm3l
rm3l previously requested changes Jan 9, 2025
examples/showcase-config.yaml Outdated Show resolved Hide resolved
Copy link
Member

@rm3l rm3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Jan 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rm3l

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jan 9, 2025
@nickboldt nickboldt merged commit 66f9645 into main Jan 9, 2025
6 of 7 checks passed
@nickboldt nickboldt deleted the migrate-showcase-rhdh branch January 9, 2025 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants