Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please do not override paste #1115

Closed
alexdima opened this issue Oct 22, 2019 · 8 comments · Fixed by #1116
Closed

Please do not override paste #1115

alexdima opened this issue Oct 22, 2019 · 8 comments · Fixed by #1116

Comments

@alexdima
Copy link

alexdima commented Oct 22, 2019

Hi, I'm a VS Code developer and we started to notice a number of issues lately regarding paste being broken:

Please consider removing this functionality or talk to us so we can add necessary API to enable format on paste. cc @jrieken @egamma


Steps To Reproduce
  1. create multiple cursors and copy
  2. move to another region and paste
Current Result
Expected Result
Additional Informations
@egamma
Copy link

egamma commented Oct 22, 2019

//fyi @akaroml

@fbricon
Copy link
Collaborator

fbricon commented Oct 22, 2019

The bug is fixed, but I'll disable the feature by default for starters, will release an update ASAP.

@fbricon
Copy link
Collaborator

fbricon commented Oct 22, 2019

@alexandrudima @akaroml @testforstephen see proposed fix in #1116. I'll cut a release once merged.

@jrieken
Copy link

jrieken commented Oct 23, 2019

@fbricon What are you trying to do on paste? Run formatter or run code actions? The former already exists via editor.formatOnPaste and it will call available DocumentRangeFormattingEditProviders, the latter doesn't exists but would be a valid feature request imo (/cc @mjbvz)

@fbricon
Copy link
Collaborator

fbricon commented Oct 23, 2019

@jrieken I want to trigger organize import on paste. See microsoft/vscode#43718

@jrieken
Copy link

jrieken commented Oct 23, 2019

Thanks - I'll make sure it's on our radar

@fbricon
Copy link
Collaborator

fbricon commented Oct 23, 2019

vscode-java 0.52.0 has been released with the fix. The original paste action is no longer overridden. You now need to paste with Ctrl+Shift+v (Cmd+Shift+v on mac) to enjoy the auto import on paste.

@alexdima
Copy link
Author

Thank you for the prompt fix ❤️ !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants