-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How can I add bazel support? #1825
Labels
Milestone
Comments
Seems that we need to have a new contribution point that allow other extension to register the build file pattern. (Something like what we have for ProposalMaybe a new entry named as
Any other ideas are open for discussion. |
LeonovecSergey
added a commit
to LeonovecSergey/vscode-java
that referenced
this issue
Mar 24, 2021
…e build file pattern. Close redhat-developer#1825 Signed-off-by: Siarhei Leanavets [email protected]
LeonovecSergey
added a commit
to LeonovecSergey/vscode-java
that referenced
this issue
Mar 24, 2021
…e build file pattern. Close redhat-developer#1825 Signed-off-by: Siarhei Leanavets [email protected] Signed-off-by: Siarhei Leanavets <[email protected]>
fbricon
pushed a commit
that referenced
this issue
Apr 20, 2021
…e build file pattern. Close #1825 Signed-off-by: Siarhei Leanavets [email protected] Signed-off-by: Siarhei Leanavets <[email protected]>
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hello,
I'm trying to add bazel support to vascode-java using the lsp server. Unfortunately some hardcode in vscode-java prevents me from doing this. For instance, in standardLanguageClient.ts there is a function:
function isJavaConfigFile(path: String) {
return path.endsWith('pom.xml') || path.endsWith('.gradle');
}
When the project file is updated, this function prevents from sending the command to eclipse.jdt.ls to update the project. More or less correct function should look like this:
function isJavaConfigFile(path: String) {
return path.endsWith('pom.xml') || path.endsWith('.gradle')
|| path.endsWith('BUILD') || path.endsWith('WORKSPACE');
}
But if the bazel support is not added to vscode, then this function will contain invalid behavior.
So my question is the following: what is the correct way to add bazel support in general and fix function isJavaConfigFile() in particular?
The text was updated successfully, but these errors were encountered: