Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider to adopt new createStatusBarItem API for id and name properties #1982

Closed
bpasero opened this issue Jun 15, 2021 · 1 comment · Fixed by #2083
Closed

Consider to adopt new createStatusBarItem API for id and name properties #1982

bpasero opened this issue Jun 15, 2021 · 1 comment · Fixed by #2083

Comments

@bpasero
Copy link

bpasero commented Jun 15, 2021

👋 Hi there, Ben here, from the VS Code team.

We just released VSCode 1.57 that landed a new stable API for status bar items to provide id and name properties: https://code.visualstudio.com/updates/v1_57#_status-bar-item-id-and-name-properties

I noticed that your extension is a consumer of the createStatusBarItem API.

Here is an example how using the new API will improve the user experience around managing status bar items:

Without id / name right clicking on the status bar item from your extension will show a generic label that is just the name of the extension:

statusbar

As you can see from the example above, the GH Pull Request extension did not yet adopt this new API and as such, the menu only shows a generic entry (as opposed to the other entries that are more specific).

Another motivation to adopt this new API is that it will enable a user to selectively hide/show status bar entries from your extension in case you register more than one status bar item.

An adoption of the new API involves:

  • configuring "engines": { "vscode": "^1.57.0" } in package.json
  • where createStatusBarItem is called, add a unique id: string property as first parameter
  • in the returned StatusBarItem set name to something that describes the intent of the status bar entry (if you provide multiple status bar entries, make sure the name is different for each entry)

Thanks for the support and the great work! ❤️

@rgrunber
Copy link
Member

Thanks for filing. In lightweight mode our extension should probably be named something like "Java Server Mode" (since it allows switching to standard mode) and in Standard mode it should probably be "Java Runtime Configuration".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants