Adopt new createStatusBarItem API

[jdneo]

resolve #1982

Here is the appearance in standard mode

Here is the appearance in Lightweight mode

Signed-off-by: Sheng Chen [email protected]

[Eskibear]

LGTM.

Current it's showing extension name instead of a meaningful name of the item, as shown below:

[rgrunber]

Is it possible to maintain support with 1.53.2 while adopting this change (ie. not bumping up?). Similar to https://github.com/redhat-developer/vscode-java/pull/1975/files .

@fbricon , I think Theia is still on 1.50.0, and likely doesn't support this new API.

[fbricon]

probably, but that requires guarding against the unavailable APIs

[jdneo]

The new createStatusBarItem() is an overload method, which I guess we need to use the version field to check which version of the API should be used. Do you think this is accpetable? (we may need to introduce a new npm module: semver to do the version comparing)

[rgrunber]

The new createStatusBarItem() is an overload method, which I guess we need to use the version field to check which version of the API should be used. Do you think this is accpetable? (we may need to introduce a new npm module: semver to do the version comparing)

I guess if this is the only way to approach this, we'd have to do it. It seems to already be a transitive dependency of other requirements we have.

In the future, we can also use https://che-incubator.github.io/vscode-theia-comparator/status.html to track API differences for things we may want to adopt.

[jdneo]

Cool table for API tracking, thanks!

[rgrunber]

Just a few changes to make so that this change is compatible with 1.53. Otherwise, I can confirm it works in VS Code.

[jdneo]

@rgrunber Thanks it works for me as well. I just updated the PR.