Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix checkJavaVersion for Windows #1360

Merged
merged 1 commit into from
Apr 6, 2020
Merged

fix checkJavaVersion for Windows #1360

merged 1 commit into from
Apr 6, 2020

Conversation

Eskibear
Copy link
Contributor

@Eskibear Eskibear commented Apr 3, 2020

Originally reported in microsoft/vscode-java-pack#351

The pack-installer uses the same logic to check java version, error below:

{
  "killed": false,
  "code": 1,
  "signal": null,
  "cmd": "C:\\Program Files\\AdoptOpenJDK\\jdk-11.0.6.10-hotspot\\/bin/java -version"
}

@fbricon fbricon added this to the Mid April 2020 milestone Apr 6, 2020
@fbricon fbricon added the bug label Apr 6, 2020
@fbricon fbricon merged commit 3edeb3a into redhat-developer:master Apr 6, 2020
@fbricon
Copy link
Collaborator

fbricon commented Apr 6, 2020

Thanks @Eskibear !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
Mid April 2020
Development

Successfully merging this pull request may close these issues.
2 participants
@Eskibear @fbricon