Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require Java 11 to run the extension #1524

Merged
merged 1 commit into from
Jul 16, 2020

Conversation

fbricon
Copy link
Collaborator

@fbricon fbricon commented Jul 15, 2020

@fbricon fbricon requested a review from snjeza July 15, 2020 16:41
@fbricon fbricon added this to the End July 2020 milestone Jul 15, 2020
@snjeza snjeza self-requested a review July 15, 2020 19:59
{
public static void main( String[] args )
{
System.out.println( "Hello World!"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just wondering what's this file for?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch. Removed it

@fbricon fbricon merged commit 315455f into redhat-developer:master Jul 16, 2020
@frankxls
Copy link

I'm not able to run some projects in Java 8 anymore. I guess is because of this "enhancement", however I still need to run such version. If not, there's no point in using VSCode and this extension. Thanks anyway.

@fbricon
Copy link
Collaborator Author

fbricon commented Jul 22, 2020

@qq849546387
Copy link

I have setting "java.configuration.runtimes", but no effect, so I hava to change it to v0.64.1.

@tigerinus
Copy link

@frankxls @qq849546387 - from the description it sounds like JDK11 is only needed for this extension to run. It should not impact your JDK8 based development work if you setup is correct.

JDK8 is mandatory to my work too. I do not need to change either my JDK_HOME or JAVA_HOME pointing to JDK8/JRE8. My setup below works fine for me:

    "java.home": "/opt/jdk11",
    "java.configuration.runtimes": [
        {
            "name": "JavaSE-1.8",
            "path": "/opt/jdk8",
            "default": true
        }
    ]

On the other hand for owners of this extension, maybe you should consider adding a new setting like jdt.java.home (in the same way like xml.java.home from XML extension and metals.javaHome from Scala extension), instead of using java.home.

@gajduk
Copy link

gajduk commented Aug 3, 2020

enhancement - Is that the new word for breaking change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants