-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require Java 11 to run the extension #1524
Conversation
{ | ||
public static void main( String[] args ) | ||
{ | ||
System.out.println( "Hello World!" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just wondering what's this file for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch. Removed it
Signed-off-by: Fred Bricon <[email protected]>
I'm not able to run some projects in Java 8 anymore. I guess is because of this "enhancement", however I still need to run such version. If not, there's no point in using VSCode and this extension. Thanks anyway. |
I have setting "java.configuration.runtimes", but no effect, so I hava to change it to v0.64.1. |
@frankxls @qq849546387 - from the description it sounds like JDK11 is only needed for this extension to run. It should not impact your JDK8 based development work if you setup is correct. JDK8 is mandatory to my work too. I do not need to change either my "java.home": "/opt/jdk11",
"java.configuration.runtimes": [
{
"name": "JavaSE-1.8",
"path": "/opt/jdk8",
"default": true
}
] On the other hand for owners of this extension, maybe you should consider adding a new setting like |
enhancement - Is that the new word for breaking change? |
follow up on eclipse-jdtls/eclipse.jdt.ls#1509