Support to specify source paths for unmanaged folder #1799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdneo
commented
Feb 22, 2021
| @@ -23,6 +24,9 @@ export function registerCommands(context: ExtensionContext) { | |||
| context.subscriptions.push(commands.registerCommand(Commands.ADD_TO_SOURCEPATH, async (uri: Uri) => { | |||
| const result = await <any>commands.executeCommand(Commands.EXECUTE_WORKSPACE_COMMAND, Commands.ADD_TO_SOURCEPATH, uri.toString()); | |||
| if (result.status) { | |||
| if (result.sourcePaths) { | |||
There was a problem hiding this comment.
The reason for this added patch is that I hope the vscode setting can also be updated if the user changes the source paths from the explorer.
While the side effect is that the setting change event will be synced to the server side and update the classpath again.
|
👋 @testforstephen @rgrunber Have time to take a look at this PR 😃 ? |
| "default": "", | ||
| "scope": "window" | ||
| }, | ||
| "java.project.sourcePaths": { |
There was a problem hiding this comment.
Update New settings to README as well.
README.md
Outdated
| @@ -155,6 +155,8 @@ The following settings are supported: | |||
| * `java.codeGeneration.toString.limitElements`: Limit number of items in arrays/collections/maps to list, if 0 then list all. Defaults to `0`. | |||
| * `java.selectionRange.enabled`: Enable/disable Smart Selection support for Java. Disabling this option will not affect the VS Code built-in word-based and bracket-based smart selection. | |||
| * `java.showBuildStatusOnStart.enabled`: Automatically show build status on startup. Defaults to `false`. | |||
| * `java.project.sourcePaths`: Relative paths to the workspace where stores the source files. `Only` effective in the `WORKSPACE` scope. The setting will `NOT` affect Maven or Gradle project. | |||
There was a problem hiding this comment.
Please refer to https://github.com/redhat-developer/vscode-java/pull/1773/files, usually we put new settings in "New in 0.77.0" first.
|
@jdneo could you resolve the conflicts? |
Signed-off-by: Sheng Chen <[email protected]>
Signed-off-by: Sheng Chen <[email protected]>
Signed-off-by: Sheng Chen <[email protected]>
Signed-off-by: Sheng Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #1798
Related with eclipse-jdtls/eclipse.jdt.ls#1658
Signed-off-by: Sheng Chen [email protected]