Rework rename/move refactoring support #1815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
it's more stable in 1.53. rename-refactoring.mov |
testforstephen
force-pushed
the
jinbo_move
branch
from
d2cb6cf to
c8b37c8
Compare
testforstephen
referenced
this pull request
Feb 24, 2021
- VSCode 1.53 bumped minimum GLIBCXX to 3.4.21 making it difficult to run tests on older platforms. Instead of disabling, we can use 1.52.1 runtime temporarily and eventually upgrade infrastructure. - https://code.visualstudio.com/updates/v1_53#_electron-11-update Signed-off-by: Roland Grunberg <[email protected]>
testforstephen
force-pushed
the
jinbo_move
branch
from
c8b37c8 to
8b931f6
Compare
snjeza
approved these changes
Feb 26, 2021
snjeza
approved these changes
Feb 26, 2021
jdneo
approved these changes
Mar 1, 2021
testforstephen
force-pushed
the
jinbo_move
branch
from
8b931f6 to
0cd3861
Compare
Signed-off-by: Jinbo Wang <[email protected]>
…lRenameFiles' request Signed-off-by: Jinbo Wang <[email protected]>
testforstephen
force-pushed
the
jinbo_move
branch
from
0cd3861 to
f3a9965
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jinbo Wang [email protected]
It requires eclipse-jdtls/eclipse.jdt.ls#1445
e.waitUntilAPI. Also another benefit is that it will composite the edit with the undo stack of the file operation, that means clickingctrl + zonce will undo the file rename operation and the corresponding refactoring together.