Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include server packages into vsix #182

Merged
merged 1 commit into from
Apr 19, 2017
Merged

Conversation

gorkem
Copy link
Contributor

@gorkem gorkem commented Apr 11, 2017

updates to include packages in vsix. Removes the
dependency to vscode profile on jdt.ls. Updates jenkins
pipeline and travis builds. Removes downloadManager
related code. fixes #178

@gorkem gorkem requested a review from fbricon April 11, 2017 20:33
@fbricon
Copy link
Collaborator

fbricon commented Apr 11, 2017

@gorkem gorkem force-pushed the issue178 branch 2 times, most recently from 0bf98ad to f4f08f7 Compare April 11, 2017 21:22
This will build and place the binaries under the `server` folder. Alternately you can download
and unzip a pre-built server. For pre-built server information refer to eclipse.jdt.ls
project.
This will build and place the binaries under the `server` folder. Alternately you can download and use the latest snapshot build from [Eclipse ™ JDT Language Server](https://github.com/eclipse/eclipse.jdt.ls) project with the following
Copy link
Collaborator

@fbricon fbricon Apr 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

@fbricon fbricon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall. Could add link to snapshots server binaries, but it's no biggie

updates to include packages in vsix. Removes the
dependency to vscode profile on jdt.ls. Updates jenkins
pipeline and travis builds. Removes downloadManager
related code.
@fbricon fbricon merged commit 660a890 into redhat-developer:master Apr 19, 2017
@gorkem gorkem deleted the issue178 branch April 19, 2017 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publish server included packages to marketplace
2 participants