Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set minimum for threshold settings #1868

Merged
merged 1 commit into from
Apr 8, 2021
+5 −2
Merged

Set minimum for threshold settings #1868

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -641,12 +641,15 @@
"type": "integer",
"description": "Specifies the number of imports added before a star-import declaration is used.",
"default": 99,
"scope": "window"
"scope": "window",
"minimum": 1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/eclipse/eclipse.jdt.ls/blob/b647c553ed817c1c70b278f1d3a7e047d27e54b8/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/preferences/Preferences.java#L1544-L1549

We have guarded the negative case in server side. If zero is not legal, i think we need update the condition check in server side as well.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR raised: eclipse-jdtls/eclipse.jdt.ls#1715

},
"java.sources.organizeImports.staticStarThreshold": {
"type": "integer",
"description": "Specifies the number of static imports added before a star-import declaration is used.",
"default": 99
"default": 99,
"scope": "window",
"minimum": 1
},
"java.semanticHighlighting.enabled": {
"type": "boolean",
Expand Down