-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move semantic tokens to LSP implementation #2000
Conversation
8e8bf1d
to
35b09d5
Compare
Updated |
Signed-off-by: 0dinD <[email protected]>
35b09d5
to
a465920
Compare
OK maybe it just takes a while for it to update. |
LGTM.
|
After this PR get merged, we should also update Wiki page. |
Yes, and also https://github.com/eclipse/eclipse.jdt.ls/wiki/Language-Server-Protocol-support. I'm also wondering if maybe there should be a wiki page about semantic highlighting in eclipse.jdt.ls as well, now that other clients could start using it over LSP. I was thinking supported token types/modifiers, what they correspond to in Java etc. especially since we have some non-standard ones. The wiki page in this repo could be more VS Code-specific with themeing examples, but also link back to the wiki in eclipse.jdt.ls. What do you think? It seems like anyone can edit the eclipse.jdt.ls wiki (not sure if that's intentional), so I think I could create a page like that when I have time. |
It's intentional. Please knock yourself out :-) |
@0dinD thanks! |
Requires eclipse-jdtls/eclipse.jdt.ls#1806
This PR simply removes the old client-side code for semantic tokens, which is no longer required when the implementation is moved to LSP in eclipse-jdtls/eclipse.jdt.ls#1806.
I also removed the
java.semanticHighlighting.enabled
setting, since the extension no longer has control over disabling the semantic tokens provider. But this setting can be substituted witheditor.semanticHighlighting.enabled
via language-specific editor settings for Java, which should provide the same exact result:Also, I noticed that the wiki page for semantic highlighting is a bit outdated now. Not only is
java.semanticHighlighting.enabled
not a setting anymore, the prompt to enable or disable semantic highlighting was also removed a while ago. Perhaps it's time to update it? While you're at it, a quick tip is to change the language id for the code block fromjson
tojsonc
to get rid of the annoying error highlight on the comments.