Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the zh-TW (Traditional Chinese) translation file. #2573

Merged
merged 4 commits into from
Jul 26, 2022

Conversation

codemee
Copy link
Contributor

@codemee codemee commented Jul 18, 2022

I've add the zh-TW (Traditional Chinese) translation file.

@jdneo
Copy link
Collaborator

jdneo commented Jul 25, 2022

Thank you @codemee for the contribution, according to the table https://github.com/microsoft/vscode-loc#visual-studio-code-language-packs

Would you mind to rename package.nls.zh-TW.json to package.nls.zh-tw.json. And rename package.nls.zh.json to package.nls.zh-cn.json?

@codemee
Copy link
Contributor Author

codemee commented Jul 25, 2022 via email

@jdneo
Copy link
Collaborator

jdneo commented Jul 25, 2022

Thank you! And remember to sign off your commits. :)

Copy link
Collaborator

@jdneo jdneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thank you @codemee!

@fbricon fbricon merged commit 5fa5fbc into redhat-developer:master Jul 26, 2022
@fbricon
Copy link
Collaborator

fbricon commented Jul 26, 2022

@codemee thanks for your contribution

Thank you! And remember to sign off your commits. :)

@jdneo Signing-off commits is no longer a requirement, as we moved to assume all commits are made according to DCO. See https://github.com/redhat-developer/vscode-java/blob/master/CONTRIBUTING.md#certificate-of-origin

@jdneo
Copy link
Collaborator

jdneo commented Jul 26, 2022

@fbricon I see. Thanks for the reminder.

@rgrunber rgrunber added this to the End August 2022 milestone Aug 29, 2022
@codemee
Copy link
Contributor Author

codemee commented Oct 11, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants