-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the zh-TW (Traditional Chinese) translation file. #2573
Conversation
Thank you @codemee for the contribution, according to the table https://github.com/microsoft/vscode-loc#visual-studio-code-language-packs Would you mind to rename |
No problems. I've change the filenames of the two files.
Sheng Chen ***@***.***> 於 2022年7月25日 週一 下午2:58寫道:
… Thank you @codemee <https://github.com/codemee> for the contribution,
according to the table
https://github.com/microsoft/vscode-loc#visual-studio-code-language-packs
Would you mind to rename package.nls.zh-TW.json to package.nls.zh-tw.json.
And rename package.nls.zh.json to package.nls.zh-cn.json?
—
Reply to this email directly, view it on GitHub
<#2573 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAH5MWLCDSVQQME2GL42YTLVVY3ILANCNFSM533TE3XQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
----------------------------------------------------------------------
http://www.facebook.com/meebox
https://dev.to/codemee
|
Thank you! And remember to sign off your commits. :) |
Signed-off-by: meebox <[email protected]>
Signed-off-by: meebox <[email protected]>
Signed-off-by: meebox <[email protected]>
Signed-off-by: meebox <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thank you @codemee!
@codemee thanks for your contribution
@jdneo Signing-off commits is no longer a requirement, as we moved to assume all commits are made according to DCO. See https://github.com/redhat-developer/vscode-java/blob/master/CONTRIBUTING.md#certificate-of-origin |
@fbricon I see. Thanks for the reminder. |
I just did.
Sheng Chen ***@***.***> 於 2022年7月25日 週一 下午5:07 寫道:
… Thank you! And remember to sign off your commits. :)
—
Reply to this email directly, view it on GitHub
<#2573 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAH5MWIEFAYOLRDTN4K4BSLVVZKL3ANCNFSM533TE3XQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
I've add the zh-TW (Traditional Chinese) translation file.