Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the wording in notifications consistent #2594

Merged
merged 2 commits into from
Aug 3, 2022

Conversation

jdneo
Copy link
Collaborator

@jdneo jdneo commented Jul 25, 2022

fix #2585

Signed-off-by: Sheng Chen [email protected]

@rgrunber
Copy link
Member

rgrunber commented Aug 2, 2022

We also have :

const action = 'Reload Now';

const action = 'Reload Now';

const doIt = 'Restart and delete';

const message = `The ${this.name} server crashed 5 times in the last 3 minutes. The server will not be restarted.`;

There's quite a few restart usages around the above location.

Let me know if you want to include any of these.

@jdneo
Copy link
Collaborator Author

jdneo commented Aug 3, 2022

Thanks for pointing out that. Let's make them align.

Except for the last one, since it's about the language server not the vs code window, so maybe using restart is fine here?

Signed-off-by: sheche <[email protected]>
Copy link
Member

@rgrunber rgrunber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we can leave the wording in the crash logic since restart makes more sense to me. Feel free to squash and merge when ready.

@jdneo jdneo merged commit 184111d into redhat-developer:master Aug 3, 2022
@jdneo jdneo deleted the cs/issue-2585 branch August 3, 2022 04:30
@jdneo jdneo added this to the End August 2022 milestone Aug 3, 2022
@rgrunber rgrunber removed this from the End August 2022 milestone Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keep consistent style in notification when prompted to restart/reload VSCode
2 participants