Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore .github/ and .gitignore from packaging #3057

Merged
merged 1 commit into from
Apr 11, 2023

Conversation

fbricon
Copy link
Collaborator

@fbricon fbricon commented Apr 11, 2023

Signed-off-by: Fred Bricon [email protected]

Copy link
Member

@rgrunber rgrunber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine to me. I don't see any files under .github/ or .gitignore itself end up in the vsix when i package it though. Is it a platform specific issue or just for the sake of clarity that you have them there.

@Eskibear
Copy link
Contributor

LGTM to explicit exclude them.
git related folders might already be excluded by default when packaging using vsce. But I still see .sdkmanrc there, which is not needed.

@Eskibear
Copy link
Contributor

I don't see any files under .github/ or .gitignore itself

See https://github.com/microsoft/vscode-vsce/blob/main/src/package.ts#L1489-L1523

@fbricon
Copy link
Collaborator Author

fbricon commented Apr 11, 2023

made the PR because I saw we had that issue in vscode-xml : redhat-developer/vscode-xml#891

doesn't hurt in any case

@rgrunber rgrunber merged commit abbfadf into redhat-developer:master Apr 11, 2023
@rgrunber rgrunber added this to the Early April 2023 milestone Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants