Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to lombok 1.18.28 #3117

Merged
merged 1 commit into from
May 30, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 5 additions & 16 deletions gulpfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -123,24 +123,13 @@ gulp.task('download_lombok', async function (done) {
}

await new Promise(function (resolve, reject) {
// Adopt lombok-1.18.27 edge release for the issue https://github.com/redhat-developer/vscode-java/issues/2887
download("https://projectlombok.org/lombok-edge.jar")
const lombokVersion = '1.18.28';
// The latest lombok version can be found on the website https://projectlombok.org/downloads
const lombokUrl = `https://projectlombok.org/downloads/lombok-${lombokVersion}.jar`;
download(lombokUrl)
.pipe(gulp.dest('./lombok/'))
.on("error", reject)
.on('end', () => {
fse.renameSync("./lombok/lombok-edge.jar", "./lombok/lombok-1.18.27.jar");
resolve();
});

// TODO: Switch to stable version once lombok 1.18.28 is released.

// const lombokVersion = '1.18.24';
// // The latest lombok version can be found on the website https://projectlombok.org/downloads
// const lombokUrl = `https://projectlombok.org/downloads/lombok-${lombokVersion}.jar`;
// download(lombokUrl)
// .pipe(gulp.dest('./lombok/'))
// .on("error", reject)
// .on('end', resolve);
.on('end', resolve);
});
done();
});
Expand Down