-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Track the LSP request data from syntax server #3278
Conversation
@rgrunber Could you consider whether you want to measure the completion performance separately for the syntax server and the standard server? vscode-java/src/standardLanguageClient.ts Lines 825 to 840 in 4352492
|
You're right, it makes sense to add a field in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall. I guess the final thing is just to add it as a property to the sendTelemetry
call for textCompletion
vscode-java/src/standardLanguageClient.ts Line 156 in 4352492
Another issue is that you only register the completion telemetry listener when the standard server becomes service ready. This means that it will not receive any events from the syntax server, because the syntax server is already closed at this stage. |
Yup. #3165 (review) . I think we can just move the registration to somewhere outside the standard/syntax code. Maybe after Line 276 in fedf3f7
|
Signed-off-by: Jinbo Wang <[email protected]>
- Move registerCodeCompletionTelemetryListener just before language client is initialized Signed-off-by: Roland Grunberg <[email protected]>
The syntax server lives until the standard server becomes service ready. The completion performance from syntax server is also part of the end-to-end experience of completion feature. So adding a new property to indicate whether the LSP track event originates from the syntax server.