Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Dependency Analytics extension from being recommended. #3804

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Remove Dependency Analytics extension from being recommended. #3804

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions src/extension.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ import { markdownPreviewProvider } from "./markdownPreviewProvider";
import { OutputInfoCollector } from './outputInfoCollector';
import { collectJavaExtensions, getBundlesToReload, getShortcuts, IJavaShortcut, isContributedPartUpdated } from './plugin';
import { fixJdtSchemeHoverLinks, registerClientProviders } from './providerDispatcher';
import { initialize as initializeRecommendation } from './recommendation';
import * as requirements from './requirements';
import { languageStatusBarProvider } from './runtimeStatusBarProvider';
import { serverStatusBarProvider, ShortcutQuickPickItem } from './serverStatusBarProvider';
Expand All @@ -34,7 +33,6 @@ import { convertToGlob, deleteClientLog, deleteDirectory, ensureExists, getBuild
import glob = require('glob');
import { Telemetry } from './telemetry';
import { getMessage } from './errorUtils';
import { TelemetryService } from '@redhat-developer/vscode-redhat-telemetry/lib';
import { activationProgressNotification } from "./serverTaskPresenter";
import { loadSupportedJreNames } from './jdkUtils';
import { BuildFileSelector, PICKED_BUILD_FILES, cleanupWorkspaceState } from './buildFilesSelector';
Expand Down Expand Up @@ -149,12 +147,8 @@ export async function activate(context: ExtensionContext): Promise<ExtensionAPI>
}
initializeLogFile(clientLogFile);

const telemetryService: Promise<TelemetryService> = Telemetry.startTelemetry(context);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so nothing starts the telemetry then?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed this as well 😐 , fixed a little while ago 50ed9ee .


enableJavadocSymbols();

initializeRecommendation(context, telemetryService);

registerOutOfMemoryDetection(storagePath);

cleanJavaWorkspaceStorage();
Expand Down
43 changes: 0 additions & 43 deletions src/recommendation/dependencyAnalytics.ts
View file
Open in desktop

This file was deleted.

17 changes: 0 additions & 17 deletions src/recommendation/index.ts
View file
Open in desktop

This file was deleted.