Optionally disable loading gradle from gradle wrapper #917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbricon
requested changes
May 9, 2019
package.json
Outdated
| @@ -114,16 +114,22 @@ | |||
| "description": "Traces the communication between VS Code and the Java language server.", | |||
| "scope": "window" | |||
| }, | |||
| "java.import.gradle.enabled": { | |||
There was a problem hiding this comment.
I want to keep java.import.gradle.enabled
package.json
Outdated
| "scope": "window" | ||
| }, | ||
| "java.import.maven.enabled": { | ||
| "java.gradle.wrapper.enabled": { |
There was a problem hiding this comment.
java.import.gradle.wrapper.enabled
package.json
Outdated
| "description": "Enable/disable the Gradle wrapper.", | ||
| "scope": "window" | ||
| }, | ||
| "java.gradle.version": { |
There was a problem hiding this comment.
java.import.gradle.version
|
I think it makes more sense to check
|
|
@fbricon I have updated the PR. |
fbricon
requested changes
May 14, 2019
package.json
Outdated
| "java.import.gradle.version": { | ||
| "type": "string", | ||
| "default": null, | ||
| "description": "Gradle version.", |
There was a problem hiding this comment.
Gradle version, used if the gradle wrapper is missing or disabled.
README.md
Outdated
| @@ -109,6 +109,10 @@ The following settings are supported: | |||
| * `java.codeGeneration.toString.listArrayContents`: List contents of arrays instead of using native toString(). Defaults to `true`. | |||
| * `java.codeGeneration.toString.limitElements`: Limit number of items in arrays/collections/maps to list, if 0 then list all. Defaults to `0`. | |||
|
|
|||
| *New in 0.45.0:* | |||
| * `java.import.gradle.wrapper.enabled`: Enable/disable the Gradle wrapper. | |||
| * `java.import.gradle.version`: Gradle version. | |||
There was a problem hiding this comment.
Gradle version, used if the gradle wrapper is missing or disabled.
Signed-off-by: Snjezana Peco <[email protected]>
|
@fbricon I have updated the PR. |
fbricon
approved these changes
May 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #875
Requires eclipse-jdtls/eclipse.jdt.ls#1026
I have added two new properties:
java.import.gradle.wrapper.enabledandjava.import.gradle.versionImporting a gradle project works in the following way:
Signed-off-by: Snjezana Peco [email protected]