Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support "textDocument/selectionRange" #976

Merged
merged 3 commits into from
Jul 12, 2019
Merged

Support "textDocument/selectionRange" #976

merged 3 commits into from
Jul 12, 2019

Conversation

akaroml
Copy link
Contributor

@akaroml akaroml commented Jul 10, 2019

Fix #780

@akaroml akaroml mentioned this pull request Jul 10, 2019
Merged
@Eskibear
Copy link
Contributor

Suggest to follow migration guide to use @types/vscode instead of vscode

@akaroml
Copy link
Contributor Author

akaroml commented Jul 10, 2019

Suggest to follow migration guide to use @types/vscode instead of vscode

This to me is like changing the way we reference vscode module for the purpose of TESTING. It's worth a separate issue and PR for visibility. Please help create an issue stating the cause.

@Eskibear
Copy link
Contributor

@types/vscode migration is tracked in #977

fbricon
fbricon requested changes Jul 10, 2019
View reviewed changes
Copy link
Collaborator

@fbricon fbricon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please expose the new preference in package.json and update the readme.md, listing the new feature and the new preference key in the new in 0.47.0 paragraph

@akaroml
Copy link
Contributor Author

akaroml commented Jul 12, 2019

Please expose the new preference in package.json and update the readme.md, listing the new feature and the new preference key in the new in 0.47.0 paragraph

Nice reminders. Will do!

@fbricon fbricon merged commit 89d3921 into redhat-developer:master Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbricon fbricon fbricon requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support semantic selection
3 participants
@akaroml @Eskibear @fbricon