Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to 'vscode-test' #981

Merged
merged 3 commits into from
Jul 17, 2019
Merged

Conversation

akaroml
Copy link
Contributor

@akaroml akaroml commented Jul 12, 2019

Signed-off-by: Rome Li [email protected]
Fix #977

@fbricon
Copy link
Collaborator

fbricon commented Jul 12, 2019

@akaroml Can you please fix the conflicts?

@akaroml
Copy link
Contributor Author

akaroml commented Jul 12, 2019

@akaroml Can you please fix the conflicts?

Fixed!

@akaroml
Copy link
Contributor Author

akaroml commented Jul 12, 2019

test this please

@akaroml
Copy link
Contributor Author

akaroml commented Jul 12, 2019

Just looked into the test log and it seemed to fail completely on the build server. I'll investigate next week.

Does "test this please" work for this repo? @fbricon

@fbricon
Copy link
Collaborator

fbricon commented Jul 12, 2019

no that command is for jenkins only. If you click on the Details link for the Travis check, you'll reach https://travis-ci.org/redhat-developer/vscode-java/builds/557822514?utm_source=github_status&utm_medium=notification and can manually trigger a rebuild

@fbricon
Copy link
Collaborator

fbricon commented Jul 16, 2019

The PR consistently fails to build on Travis. Also, I'm unable to rebase against master

@akaroml
Copy link
Contributor Author

akaroml commented Jul 17, 2019

The PR consistently fails to build on Travis. Also, I'm unable to rebase against master

The test was just fixed. There were path issues before the fix. Let me try to rebase.

@akaroml
Copy link
Contributor Author

akaroml commented Jul 17, 2019

Done rebasing. should be fine to merge now. @fbricon

@fbricon fbricon merged commit cf1fbe1 into redhat-developer:master Jul 17, 2019
@fbricon
Copy link
Collaborator

fbricon commented Jul 17, 2019

Thanks @akaroml !

@akaroml akaroml deleted the vscode-test branch July 17, 2019 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

replace package vscode with @types/vscode
2 participants