Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a progress bar / visual clue when loading completion is too long #58

Closed
fbricon opened this issue Sep 2, 2019 · 5 comments · Fixed by redhat-developer/quarkus-ls#180
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@fbricon
Copy link
Collaborator

fbricon commented Sep 2, 2019

Warming up the quarkus completion can take several seconds. It's unclear then, that something is happening. Users should get a visual clue enticing them to wait for a result. Whether it's a progress bar or a loading indicator in the task bar below, I guess it'll depend on what's technically possible.

@fbricon fbricon added the enhancement New feature or request label Sep 2, 2019
@angelozerr angelozerr self-assigned this Sep 25, 2019
@angelozerr angelozerr added this to the 1.1.0 milestone Sep 25, 2019
@angelozerr angelozerr removed this from the 1.1.0 milestone Oct 11, 2019
@jeffmaury
Copy link
Member

I've tested with an empty P2 repo (in order to force download of deployment JARs during getProjectInfo) and a Quarkus application with all extensions: looks good on VSCode as the UI displays 'Loading' while waiting for the response. The only issue is that the request takes several minutes to process.

@angelozerr
Copy link
Contributor

@jeffmaury we should indeed manage progress monitor on server side with clean steps. But to benefit with this feature we need progress support. Even if JDT LS has implemented custom progress we would like to use LSP progress to benefit with this feature with another LSP clients (Eclipse IDE and IJ for you).

To implement this issue, we need:

@jeffmaury
Copy link
Member

Not sure to understand the workflow in this specific case as the long process is outside of the LS. But maybe I'm missing something

@angelozerr
Copy link
Contributor

angelozerr commented Dec 6, 2019

as the long process is outside of the LS

Yes but according my understand, the call of IProgressMonitor.worked(int work) should generate an LSP progress notification.

@fbricon
Copy link
Collaborator Author

fbricon commented Jan 8, 2020

that's how it looks in vscode now:
Jan-07-2020 17-17-26

@fbricon fbricon closed this as completed Jan 8, 2020
@xorye xorye changed the title Should add a progress bar / visual clue when loading completion is too long Add a progress bar / visual clue when loading completion is too long Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants