Should add a progress bar / visual clue when loading completion is too long #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angelozerr
force-pushed
the
progress
branch
5 times, most recently
from
6cdcee9 to
7180469
Compare
fbricon
requested changes
Jan 7, 2020
....microprofile.jdt.core/src/main/java/com/redhat/microprofile/jdt/core/PropertiesManager.java
Show resolved
Hide resolved
....microprofile.jdt.core/src/main/java/com/redhat/microprofile/jdt/core/PropertiesManager.java
Show resolved
Hide resolved
....microprofile.jdt.core/src/main/java/com/redhat/microprofile/jdt/core/PropertiesManager.java
Outdated
Show resolved
Hide resolved
long Fixes redhat-developer#58 Signed-off-by: azerr <[email protected]>
|
that's how it looks in vscode: |
And do you like it? Do you want some changes? |
|
I'm curious to see why we're seeing "Scanning properties" twice. That bothers me |
|
@fbricon I tried to fix it without success, but it seems it's a bug coming from JDT LS. There is the same problem for
|
|
ok then, @angelozerr can you please open a ticket in vscode-java? |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should add a progress bar / visual clue when loading completion is too
Fixes redhat-developer/vscode-quarkus#58
Signed-off-by: azerr [email protected]