Replace axios library with built-in fetch #711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datho7561
force-pushed
the
use-fetch-instead-of-axios
branch
3 times, most recently
from
c0b2d99 to
fb6bee4
Compare
|
axios will still be pulled in as a transitive dependency from |
Signed-off-by: David Thompson <[email protected]>
datho7561
force-pushed
the
use-fetch-instead-of-axios
branch
from
fb6bee4 to
3f4240f
Compare
|
@angelozerr this might fix the issue with the proxy described in #680 (comment) (This is not the bug that the person filing the issue encountered, but it should be addressed). |
|
@datho7561 I will test your PR without proxy. If it is working can I merge it? |
|
Okay sounds good |
|
It works like a charm (tested without proxy), thanks @datho7561 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: David Thompson [email protected]