-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Type rename provider [Uses VS Code proposed API] #304
Conversation
You need to use VS Code insiders: https://code.visualstudio.com/api/advanced-topics/using-proposed-api#using-a-proposed-api and set Currently, Demo for HTML: microsoft/vscode#88424 (comment) |
But we still suffer from this issue: #213 (comment) |
Signed-off-by: David Kwon <[email protected]>
@@ -9,6 +9,7 @@ | |||
"license": "EPL-1.0", | |||
"bugs": "https://github.com/redhat-developer/vscode-xml/issues", | |||
"preview": true, | |||
"enableProposedApi": true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can only use it in insiders. The marketplace rejects publishing when enableProposedApi:true
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to wait for microsoft/vscode#105394
It's very strange because this problem should be fixed. The only problem that I have seen is when you do this usecase with a XML element which doesnt comes from a XSD Schema (but it seems that it's not our usecase). In the demo, I noticed that when you remove the d character completion opens, inmy case the completion is not opened (I must do a Ctrl+Space to open completion). Is there a settings for that? |
Please note the onTypeRanme is now in the LSP 3.16 specification. I have created an issue in LSP4J eclipse-lsp4j/lsp4j#469 If I understand correctly, we will avoid developping TypeScript code for supporting mirror cursor. |
Today this type rename provider became linked editing range with a LSP specification. This PR is replaced with #432 |
Follows HTML's implementation: microsoft/vscode@01e01b1
To test this PR, you need the server side PR as well eclipse-lemminx/lemminx#836
Signed-off-by: David Kwon [email protected]