-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
completionHelper will break yaml file if it contains \r charactor #37
Comments
I can reproduce this problem but it seems to me like that function isn't really intended to be API. Why are you calling this function instead of using the language service anyway, @andxu? |
I am using the yaml language server in vscode-yaml extension, I found some completions are not right so I take a look at the code and found it is caused by \r, so I opened an issue here, and I will open a PR to fix it. |
… it contains \r charactor at redhat-developer#37
fix issue #37 completionHelper will break yaml file if it contains \r …
Thanks for the PR! |
Here is the code to repro the test
The test has output of "test\r:\r\no:bar\r\n" (foo has been cut off first two charactors 'fo'
The text was updated successfully, but these errors were encountered: