Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: completion invoke when next line has an indented comment #724

Merged
merged 6 commits into from
Jun 21, 2022
Merged

fix: completion invoke when next line has an indented comment #724

merged 6 commits into from
Jun 21, 2022

Conversation

rickcowan
Copy link
Contributor

@rickcowan rickcowan commented Jun 2, 2022 •
edited
Loading

What does this PR do?

fix: completion invoke when next line has an indented comment

The change for this was to evaluate range[1] (value-end) rather than range[2] (node-end, which may contain trivia such as comments) when trying to find the closest node.

example:
  prop1: "test"
  # cursor here
    #comment

What issues does this PR fix or reference?

no ref

Is it tested? How?

added unit tests

@rickcowan rickcowan marked this pull request as ready for review June 2, 2022 18:53
@grant-d grant-d mentioned this pull request Jun 2, 2022
Merged
@gorkem
Copy link
Collaborator

gorkem commented Jun 3, 2022

Looks like it failed prettier checks. yarn build should have caught them. Can you update the PR with the fixes.

@coveralls
Copy link

coveralls commented Jun 4, 2022 •
edited
Loading

Coverage Status

Coverage increased (+0.03%) to 82.48% when pulling 05ea9e8 on p-spacek:fix/indented_comment into 44bce9b on redhat-developer:main.

@gorkem
Copy link
Collaborator

gorkem commented Jun 9, 2022

@p-spacek do you mind reviewing this one?

gorkem
gorkem approved these changes Jun 11, 2022
View reviewed changes
Copy link
Collaborator

@gorkem gorkem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gorkem
Copy link
Collaborator

gorkem commented Jun 11, 2022

Great catch, thank you for the contribution. I think this got a conflict on the test after another contribution was merged.

@p-spacek
Copy link
Contributor

@p-spacek do you mind reviewing this one?

We were cooperating together with Rick on this issue. So from my point of view, it's ok.
@rickcowan can you please check the conflict and tests after the merge?

msivasubramaniaan
msivasubramaniaan approved these changes Jun 21, 2022
View reviewed changes
Copy link
Contributor

@msivasubramaniaan msivasubramaniaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msivasubramaniaan msivasubramaniaan merged commit 1b0d4b2 into redhat-developer:main Jun 21, 2022
@rickcowan rickcowan deleted the fix/indented_comment branch June 22, 2022 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gorkem gorkem gorkem approved these changes

@msivasubramaniaan msivasubramaniaan msivasubramaniaan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rickcowan @gorkem @coveralls @p-spacek @msivasubramaniaan