fix: proper indenting of snippet within an array

src/languageservice/services/yamlCompletion.ts

@@ -634,6 +634,7 @@ export class YamlCompletion {
     const lineContent = textBuffer.getLineContent(overwriteRange.start.line);
     const hasOnlyWhitespace = lineContent.trim().length === 0;
     const hasColon = lineContent.indexOf(':') !== -1;
+    const isInArray = lineContent.trimLeft().indexOf('-') === 0;
     const nodeParent = doc.getParent(node);
     const matchOriginal = matchingSchemas.find((it) => it.node.internalNode === originalNode && it.schema.properties);
     for (const schema of matchingSchemas) {
@@ -644,7 +645,7 @@ export class YamlCompletion {
         this.collectDefaultSnippets(schema.schema, separatorAfter, collector, {
           newLineFirst: false,
           indentFirstObject: false,
-          shouldIndentWithTab: false,
+          shouldIndentWithTab: isInArray,
         });
 
         const schemaProperties = schema.schema.properties;

test/defaultSnippets.test.ts

@@ -232,7 +232,7 @@ describe('Default Snippet Tests', () => {
       const completion = parseSetup(content);
       completion
         .then(function (result) {
-          assert.equal(result.items.length, 14); // This is just checking the total number of snippets in the defaultSnippets.json
+          assert.equal(result.items.length, 15); // This is just checking the total number of snippets in the defaultSnippets.json
           assert.equal(result.items[4].label, 'longSnippet');
           // eslint-disable-next-line
           assert.equal(
@@ -303,6 +303,17 @@ describe('Default Snippet Tests', () => {
         .then(done, done);
     });
 
+    it('Test snippet in array indented completion', (done) => {
+      const content = 'arrayWithSnippet:\n  - ';
+      const completion = parseSetup(content, content.length);
+      completion
+        .then(function (result) {
+          assert.equal(result.items.length, 4);
+          assert.equal(result.items[0].insertText, 'item1: $1\n  item2: $2');
+        })
+        .then(done, done);
+    });
+
     it('Test array of objects extra new line', (done) => {
       const content = 'arrayObjectSnippet:\n  ';
       const completion = parseSetup(content, content.length);

test/fixtures/defaultSnippets.json

@@ -216,6 +216,18 @@
           "suggestionKind": 9
         }
       ]
+    },
+    "arrayWithSnippet": {
+      "type": "array",
+      "items": {
+        "defaultSnippets": [
+          {
+            "label": "My array item",
+            "body": { "item1": "$1", "item2": "$2" }
+          }
+        ],
+        "type": "string"
+      }
     }
   }
 }