Bpmilestone4 #16
Open
Bpmilestone4 #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MJSiddu
reviewed
Aug 3, 2022
| @@ -384,7 +386,7 @@ func (e *exportPullOptions) IlmtPullBase(s *datactlapi.Source, ctx context.Conte | |||
| return p | |||
| }) | |||
|
|
|||
| return productCount, productUsageResponseStr, nil | |||
| return productCount, EMPTY, nil | |||
There was a problem hiding this comment.
I don't see a need to keep 3 return values here when we are only using only the error object/response in the caller.
Comment on lines
+135
to
+144
| response := i.ilmt.FetchUsageData(ctx, dateRangeOptions, selectedDate) | ||
| check(err) | ||
|
|
||
| responseFile := fmt.Sprintf(RESPONSEFILE, archFileTempDir, selDate) | ||
| manifestFile := fmt.Sprintf(MANIFESTFILE, archFileTempDir) | ||
| manifestFileContent := MANIFESTFILECONTENT | ||
| err = ioutil.WriteFile(responseFile, response, 0644) | ||
| check(err) | ||
| err = ioutil.WriteFile(manifestFile, []byte(manifestFileContent), 0644) | ||
| check(err) |
There was a problem hiding this comment.
Calling just check(err) [here, and in many other places] is just catching err and panicking. May be we should also log appropriate error messages for each failing scenario?
MJSiddu
reviewed
Aug 3, 2022
| log.Fatal(err.Error()) | ||
| return -1, EMPTY, err | ||
| } | ||
| func (ilmtC *ilmtClient) FetchUsageData(ctx context.Context, dateRange DateRange, selectedDate time.Time) []byte { |
There was a problem hiding this comment.
Maybe we can further modularize this FetchUsageData code by moving the processing logic (2 big FOR loops) into a separate util function?
|
Crashing when I try to pull ILMT data:
|
|
Steps:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR raised