Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates buildah image push step #2

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Updates buildah image push step #2

merged 1 commit into from
Oct 17, 2023

Conversation

apoorvajagtap
Copy link
Member

buildah step in the source-to-image CBS no longer writes the image, but pushes the image directly to the output repo (spec.output.image).
This eliminates the requirement of image-processing step, and hence the need for DAC_OVERRIDE.

@apoorvajagtap
Copy link
Member Author

/assign @adambkaplan @jkhelil @coreydaley

adambkaplan
adambkaplan approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adambkaplan adambkaplan merged commit a3c777d into redhat-openshift-builds:main Oct 17, 2023
@apoorvajagtap apoorvajagtap deleted the BUILD-748 branch October 18, 2023 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkhelil jkhelil jkhelil approved these changes

@adambkaplan adambkaplan adambkaplan approved these changes

Assignees

@adambkaplan adambkaplan

@coreydaley coreydaley

@jkhelil jkhelil

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@apoorvajagtap @adambkaplan @jkhelil @coreydaley