Adds section for memcached settings in manifests #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 7, 2014 10:05
The default controller common manifest assumes that qpid is running locally on the same machine. This may or may not be the case and therefore it should take the '$qpid_host' parameter used within other manifests. Without this change, Nova attempts to use localhost as it's qpid broker, which obviously breaks if using multiple controller hosts.
The current manifests do not offer the user the chance to override the default memcached settings. It always defaults to the localhost. This change updates the manifests to allow the user to override. Note that we'll need to update the installer packages to set a default override parameter.
| @@ -102,4 +102,8 @@ | |||
| $mysql_shared_storage_type = 'MYSQL_SHARED_STORAGE_TYPE' | |||
| $mysql_clu_member_addrs = 'SPACE_SEPARATED_IP_ADDRS' | |||
| $mysql_resource_group_name = 'mysqlgroup' | |||
|
|
|||
| # Configure Memcached settings for Horizon | |||
| $cache_server_ip = '127.0.0.1' | |||
There was a problem hiding this comment.
In order for the defaults to appear in foreman, these new variables would need to be in seeds.rb as well
|
I notice that you have not added this for nova_network/controller.pp. Is that just an oversight, or is there a reason? Also, can you rebase your branch against origin/master and then force push? There is currently a dirty git history here, and it is not merge-able as is (as we didn't have time to get to is as we were finishing up a release when you posted this). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current manifests do not offer the user the chance to
override the default memcached settings. It always defaults
to the localhost. This change updates the manifests to allow
the user to override.
Note that we'll need to update the installer packages to set
a default override parameter.
BZ #1063372 - No option to specify memcache details for Horizon in manifests
https://bugzilla.redhat.com/show_bug.cgi?id=1063372