Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: How do plugins work? #119

Closed
kylelaverty opened this issue Jun 5, 2024 · 4 comments
Closed

Docs: How do plugins work? #119

kylelaverty opened this issue Jun 5, 2024 · 4 comments
Assignees

Comments

@kylelaverty
Copy link

Looking at the existing docs around the plugins it is not exactly clear what to do with the sample plugins. Where do I put them? How do I get them to work with the Docker image?

Some enhancements to the docs would be greatly appreciated.

@redimp
Copy link
Owner

redimp commented Jun 6, 2024

Hey @kylelaverty, thank you for bringing this up.

Currently the plugins have to be installed in the virtual environment that the app uses. For running this in docker, you would have to build your own docker image with the specific environment.

To make this a little easier to implement for a plugin user, a volume could be mounted in the container e.g. into /plugins and the entrypoint.sh would run pip install . each directory in the mounted folder ...

I will look into that tonight later this week.

@kylelaverty
Copy link
Author

Hey,

Thanks for the quick response. I guess I had incorrectly thought there was a specific folder to create and the wiki would scan for it and load what was there but given the use of pip this explanation makes a lot of sense.

redimp added a commit that referenced this issue Jun 7, 2024
The entrypoint.sh checks /plugins and /app-data/plugins for plugins
to install.

Added an example using docker-compose and the existing plugin examples.

The lack of documentation or examples for installing plugins was
brought up in #119.
@redimp
Copy link
Owner

redimp commented Jun 7, 2024

With the change to the entrypoint.sh the docker image will kind of do what you expected. This should make it much more approachable to develop or use plugins.

This improvement will we included in the next release. Thanks for bringing this up!

@redimp redimp self-assigned this Jun 7, 2024
@redimp
Copy link
Owner

redimp commented Jun 16, 2024

With the v2.4.3 the docker image installs plugins from either /plugins or /app-data/plugins. The examples in docs/plugin_examples provide a docker-compose.yaml as demo.

@redimp redimp closed this as completed Jun 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants