Fix the Java example code for Lists using RPUSH #4074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sazzad16
changed the title
|
@sanaulla123 Thank you for noticing. @andy-stark-redis No other examples match with redis-cli example. If you confirm, we can merge this PR. If you want to fix differently, let us know. |
andy-stark-redis
approved these changes
Jan 31, 2025
sazzad16
approved these changes
Jan 31, 2025
|
Merged. Thanks @sanaulla123 for contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the example under Capped List on the documentation page: https://redis.io/docs/latest/develop/data-types/lists/
The Java-Sync library code example is not matching the one given in Redis CLI and also not matching the problem statement: "For example, if you're adding bikes on the end of a list of repairs, but only want to worry about the 3 that have been on the list the longest:"
The right solution is to use
rpushandltrimthe first X elements.This PR fixes the code to match the Redis CLI example.