Use epoll over io_uring channel for Unix Domain Sockets #2791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mp911de
reviewed
Mar 18, 2024
| @@ -74,7 +74,7 @@ public static Class<? extends DatagramChannel> datagramChannelClass() { | |||
| public static class NativeTransports { | |||
|
|
|||
| static EventLoopResources RESOURCES = KqueueProvider.isAvailable() ? KqueueProvider.getResources() | |||
| : IOUringProvider.isAvailable() ? IOUringProvider.getResources() : EpollProvider.getResources(); | |||
| : EpollProvider.isAvailable() ? EpollProvider.getResources() : IOUringProvider.getResources(); | |||
There was a problem hiding this comment.
I would leave the order as is and only apply a tweak in the domain socket class retrieval. I'll take care of this during the merge.
mp911de
changed the title
mp911de
changed the title
mp911de
added a commit
that referenced
this pull request
Mar 18, 2024
mp911de
added a commit
that referenced
this pull request
Mar 18, 2024
|
Thank you for your contribution. That's merged, polished, and backported now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for the issue #2790
the current implementation uses io_uring as preferred.
the change contains switch of precedence to use epoll over io_uring.
I did some reading on the performance comparisons of io_uring and epoll;
io_uring is considered faster than epoll in some cases and not in others. -> axboe/liburing#536
Since we are changing default behavior when both of them are available, there will be some performance change for clients that have both in runtime.
i cant evaluate exactly how big the impact is and/or how many client will be impacted.
happy to hear any comments.