-
Notifications
You must be signed in to change notification settings - Fork 996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test modules CONFIG support #3103
Conversation
(similar to the other issue) |
PR 3145 will not help in this case. 8.0 env is still bootstrapped by building it locally. When building locally with |
Same, about the conflicts |
@tishun Done! |
Hey, seems there are also some test failures, could you please take a look at that? |
src/test/java/io/lettuce/core/commands/ConsolidatedConfigurationCommandIntegrationTests.java
Show resolved
Hide resolved
src/test/java/io/lettuce/core/commands/ConsolidatedConfigurationCommandIntegrationTests.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To expand on my thoughts on Ivo's suggestion for using a parametrized test:
Advantages
- (generally) if we want to change the steps of the tests we would make the change only in one place and only rotate parameters
- adding and removing test parameters (scenarios) is easy
Disadvantages
- (generally) we would assume that all these tests require the same steps always and if this changes we would need to extract them again
No clear winner for me, so I leave this to you folks to agree on
Redis 8 now includes module capabilities, which means that module-specific configuration parameters should be configurable via the the Redis CONFIG command. Enhance integration tests to validate that we can get/set module-specific settings
mvn formatter:format
target. Don’t submit any formatting related changes.