Allow automatic pings to be sent on pubsub channel #2371
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If you turn on automatic pings (via pingInterval) on a pubsub channel, you get the error: “Cannot send commands in PubSub mode”. PING is one of the legal commands on a pubsub channel, so we override the ping call to set ignorePubSubMode true and allow the ping to be sent on that channel.
We are unable to use the new pingInterval setting on clients being used for pubsub because of an incorrect error that PING is not allowed on pubsub channels.
Checklist
npm test
pass with this change (including linting)?