Fix Sentinel.execute_command to execute across the entire sentinel cl…

…uster (#2459) * Change sentinel execute command to execute across the entire cluster * Add change to CHANGES file
redis · Nov 21, 2022 · e425674 · e425674
1 parent 59c8e7d
commit e425674
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/CHANGES b/CHANGES
@@ -28,6 +28,7 @@
     * Fixed "cannot pickle '_thread.lock' object" bug (#2354, #2297)
     * Added CredentialsProvider class to support password rotation
     * Enable Lock for asyncio cluster mode
+    * Fix Sentinel.execute_command doesn't execute across the entire sentinel cluster bug (#2458)
 
 * 4.1.3 (Feb 8, 2022)
     * Fix flushdb and flushall (#1926)

diff --git a/redis/sentinel.py b/redis/sentinel.py
@@ -200,10 +200,10 @@ def execute_command(self, *args, **kwargs):
             kwargs.pop("once")
 
         if once:
+            random.choice(self.sentinels).execute_command(*args, **kwargs)
+        else:
             for sentinel in self.sentinels:
                 sentinel.execute_command(*args, **kwargs)
-        else:
-            random.choice(self.sentinels).execute_command(*args, **kwargs)
         return True
 
     def __repr__(self):